fix: wide screen ui scales better #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeruvalcaba
approved these changes
Nov 22, 2021
app/react-native/src/preview/components/OnDeviceUI/OnDeviceUI.tsx
Outdated
Show resolved
Hide resolved
app/react-native/src/preview/components/OnDeviceUI/animation.ts
Outdated
Show resolved
Hide resolved
app/react-native/src/preview/components/OnDeviceUI/animation.ts
Outdated
Show resolved
Hide resolved
|
@jorgeruvalcaba thanks for the review 🙇 |
dannyhw
added a commit
to raychanks/react-native
that referenced
this pull request
Feb 7, 2022
* fix: wide screen ui scales better * fix: allow ipads in example * refactor: use constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #163
Previously the menu would always scale to 70% of the screen, now if the screen is 1024 or wider it will scale to be 30% and the preview will be 70%.
What I did
I adjusted the scaling animation so it flips the size of the menu and preview on wide screens for a better experience on the web or ipads etc.
How to test
run the example app on the web
screenshots