feat: config location is now flexible and paths relative from main.js #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a small change to prevent the on add from being ran for every file on the intial setup of the watcher. |
jgornick
reviewed
Oct 8, 2021
|
Added some unit tests for the loader file to validate a few things. The beginning of more testing to come in the future 🙂. |
jgornick
reviewed
Oct 8, 2021
jgornick
reviewed
Oct 8, 2021
jgornick
reviewed
Oct 8, 2021
|
Will merge this tomorrow and create a new alpha build |
dannyhw
added a commit
to raychanks/react-native
that referenced
this pull request
Feb 7, 2022
…storybookjs#278) - you can now specify a config location and you can change the folder name storybookjs#278 - note that this folder should still contain all the same files - `—absolute` option will use absolute imports in the requires.js file - paths in general should work better with the watcher and get stories script - In main.js stories are relative from the config directory and no longer add "../", this should fix absolute paths and other bugs storybookjs#278 - `sbn-get-stories` and `sbn-watcher` are now `sb-rn-get-stories` and `sb-rn-watcher`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #275
What I did
I've changed the get stories and watcher commands so that you can now pass a config path which will be used to determine your .storybook folder location (you can call .storybook something else now).
I've also added prettier and commander to make the code a bit easier to work with.
How to test
Please explain how to test your changes and consider the following questions