docs: Fixes #247 by editing the v6 alpha guide with instructions on how to set up with Expo #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions on how to set up with Expo. Also fixes linter warning in README.md.
dannyhw
approved these changes
Aug 15, 2021
v6README.md
Outdated
| ```shell | ||
| npm install --global expo-cli | ||
| expo init appName | ||
| # select blank TypeScript template when prompted |
There was a problem hiding this comment.
You can specify the template with --template I think
v6README.md
Outdated
|
|
||
| Update your metro config to have `resolver:{resolverMainFields: ['sbmodern', 'main']}`. | ||
| This enables us to use the modern build of storybook instead of the polyfilled versions | ||
| For React Native without Expo, update your metro config to have `resolver:{resolverMainFields: ['sbmodern', 'main']}`. |
There was a problem hiding this comment.
Resolver main fields is what fixes the promises bug. The issue with expo is more that we need to extend the default config instead of replacing resolver main fields we can just add sbmodern like default.resolver.resolverMainfields = ['sbmodern', ...default.resolver.resolverMainfields ]
See the expo docs on metro configs and you'll see what I mean.
dannyhw
pushed a commit
to raychanks/react-native
that referenced
this pull request
Feb 7, 2022
…ctions on how to set up with Expo (storybookjs#250) * docs: Fixes storybookjs#247 by editing the v6 alpha guide with instructions on how to set up with Expo. Also fixes linter warning in README.md. * docs: Updated the V6 Alpha readme with the Expo metro config as discussed in storybookjs#247 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes linter warning in README.md.
Issue: #247
What I did
Slightly modified the v6 alpha guide so that 6.0 alpha can also be set up on Expo. Notice that there still seem to be some issues with Expo (e.g. the React Native hooks, see #247 (comment))
How to test
Test the modified v6 alpha guide to ensure that it is understandable & produces a working setup on Expo (and on vanilla React Native, if the user so chooses).