refactor: Refactor class components in addons to function components #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyhw
approved these changes
Aug 5, 2021
| typeof value === 'object' && | ||
| !Array.isArray(value) && | ||
| Object.keys(value).length)) ? ( | ||
| <Button |
There was a problem hiding this comment.
Not necessary for this pr I guess but it might be good to replace this button with a custom touchable opacity or pressable to improve the UI for the Android version.
There was a problem hiding this comment.
Good idea! Didn't do that yet, but we could tackle it either in this PR or as a separate PR.
…o function components
lauriharpf
changed the title
…n components. Omissions: * ondevice-controls/src/GroupTabs.tsx: Not refactored, as the component is currently unused. Let's take it into use before refactoring or remove it (see storybookjs#182 (comment)) * ondevice-controls/src/components/color-picker/*: Let's try to get the fixes PR'd and merged to the original library (so we can remove this code) or try to find a color picker that doesn't need custom modifications
…omponents. As the last ondevice-addon to refactor, this fixes storybookjs#235
lauriharpf
changed the title
lauriharpf
added a commit
to lauriharpf/react-native
that referenced
this pull request
Aug 8, 2021
dannyhw
pushed a commit
that referenced
this pull request
Aug 9, 2021
dannyhw
pushed a commit
to raychanks/react-native
that referenced
this pull request
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #235
What I did
Fixes #235 by refactoring the class components in all ondevice addons to function components. Note the exceptions mentioned in the comments of commit b671dd6
How to test
Run the example app at
examples/nativeand experiment with the addons.