feat: add date control type #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauriharpf
reviewed
Jul 14, 2021
lauriharpf
reviewed
Jul 14, 2021
| }; | ||
| } | ||
| const DateType = ({ onChange, arg: { name, value } }: DateProps) => { | ||
| const [isDateVisible, setIsDateVisible] = useState(false); |
There was a problem hiding this comment.
This split to two different boolean variables (isDateVisible and isTimeVisible) pre-dates your code, but I'm tempted to suggest a small refactor here: #225
It's by no means a priority or a blocker, but thought you might be able to take a quick peek now that this code is fresh in the minds of both of us.
There was a problem hiding this comment.
accepted your PR, seems like a great idea to me. Thanks again!
lauriharpf
reviewed
Jul 14, 2021
lauriharpf
approved these changes
Jul 14, 2021
add time to date example Co-authored-by: Lauri Harpf <[email protected]>
Co-authored-by: Lauri Harpf <[email protected]>
…an values ("isDateVisible" and "isTimeVisible") allow for one invalid state (both shouldn't be true at the same time, as that would mean both pickers are visible simultaneously, which can't happen with the current implementation). (#225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #199
What I did
I added the date control type
I also updated the date picker library to resolve the yellow warnings it triggered previously and fix the web version of this control.
How to test
First make sure you run yarn install or yarn bootstrap in the root and then run pod install in the example app