Modified instructions for running example app in the repo #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ybookjs#186 and current next-6.0 branch content
dannyhw
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #186
What I did
Modified instructions to run example apps to match discussion in #186 and current next-6.0 branch content
How to test
Follow the instructions and confirm that the example works as expected.
Additional details
Also removed the parts referring to the Expo app, which doesn't exist in
next-6.0at the moment. It exists in themasterbranch, so didn't remove the mention from the "Reproductions" section. If thecrna-kitchen-sinkexample is later ported to 6.0, then that part of the documentation should be re-added.