chore: Remove expo projects and remove no-hoisting #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyhw
reviewed
May 12, 2021
There was a problem hiding this comment.
Looks good, I had an issue when running android though, could you check?
FAILURE: Build failed with an exception.
* What went wrong:
Could not initialize class org.codehaus.groovy.runtime.InvokerHelper
__
after all it was a problem with my java_home variable. Looks good to me 👍
|
thanks for your contribution 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #162
What I did
In order to make the monorepo a bit more manageable I've removed
no-hoistingdirectives so that all packages can share the same installation of react and react-native. Since expo uses their own version of react-native and thus wouldn't work with hoisting, these examples have been removed as they provided little value anyways. Expo brought react-native-web setup, but we'll be adding that ourselves directly instead as tracked in #170.Fresh installs are now ~8x faster and react hooks work.
I've disabled Flipper on iOS as it doesn't work out of the box right now and makes compile time much slower. We can easily re-enable it later.
I chose to keep using the 0.63 range as 0.64 brings react 17, an upgrade I prefer to do in a separate PR.
How to test
Run the example project as before. Minor caveat is that you must start metro manually.