Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ondevice select knob undefined value causes key error #111

Merged
merged 1 commit into from
Oct 6, 2020
Merged

fix: ondevice select knob undefined value causes key error #111

merged 1 commit into from
Oct 6, 2020

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Oct 2, 2020 •
edited
Loading

Issue: #109

What I did

Make the key extractor a combination of key and label instead of just key.

How to test

  • create a knob with multiple selects that have undefined values

@dannyhw dannyhw added the bug Something isn't working label Oct 2, 2020
@dannyhw dannyhw merged commit e07b2f7 into master Oct 6, 2020
@dannyhw dannyhw mentioned this pull request Oct 6, 2020
Closed
This was referenced Nov 22, 2020
Merged
Merged
Closed
Closed
Closed
@dannyhw dannyhw deleted the fix/select-knob-key branch July 2, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gongreg Gongreg Awaiting requested review from Gongreg

@ndelangen ndelangen Awaiting requested review from ndelangen

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dannyhw