Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Controls tab display looks broken when story has no controls #253

Closed
lauriharpf opened this issue Aug 15, 2021 · 2 comments
Closed
Assignees

Comments

@lauriharpf
Copy link
Contributor

Describe the bug
The message displayed in the Controls tab when story has no controls configured has some issues:

  1. The text layout makes the view look "broken", as the two sentences are joined together ("controlsLearn how"...)
  2. The second sentence ("Learn how to add controls") is a link that opens the browser, but there's no visual hint - the text looks identical to the one that is not a link.
  3. There is a disabled RESET-button that has no purpose (since there are no controls, there is nothing to reset)

See screenshot below:

Screen Shot 2021-08-15 at 18 38 40

To Reproduce
Steps to reproduce the behavior:

  1. Run the example app under examples/native
  2. Select the top story ("Background StoriesOf -> Basic")
  3. Press "Addons"
  4. Open the "Controls" tab

Expected behavior
The app should show a message that doesn't have the issues described above, for example something like this:

Screen Shot 2021-08-15 at 18 37 33

@lauriharpf lauriharpf self-assigned this Aug 15, 2021
lauriharpf added a commit to lauriharpf/react-native that referenced this issue Aug 15, 2021
… tab when the story has no controls configured.
@wahyunurrosyid
Copy link

mantap

@dannyhw
Copy link
Member

dannyhw commented Aug 26, 2021

@wahyunurrosyid please don't leave comments like this that provide no value, I look through all issue comments so this just wastes time.

dannyhw pushed a commit to raychanks/react-native that referenced this issue Feb 7, 2022
… tab when the story has no controls configured. (storybookjs#254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants