Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] util and util-deprecate are not listed as dependencies and break unless installed #237

Closed
dannyhw opened this issue Jul 18, 2021 · 0 comments
Assignees
Labels
6.5 bug Something isn't working

Comments

@dannyhw
Copy link
Member

dannyhw commented Jul 18, 2021

Describe the bug

When setting up with the 6.0 alpha util and util-deprecate must be installed or the app breaks. Probably they need to be included in the @storybook/react-native package.json dependencies.

To Reproduce
Steps to reproduce the behavior:

Follow the steps at https://github.com/storybookjs/react-native/blob/next-6.0/v6README.md without installing util and util deprecate and you should get an error.

Expected behavior

There should be no error when not explicitly installing util/util-deprecate. These should be installed when @storybook/react-native is installed.

@dannyhw dannyhw added the 6.5 label Jul 18, 2021
@dannyhw dannyhw added this to the v6 alpha 2 milestone Jul 18, 2021
@dannyhw dannyhw added the bug Something isn't working label Jul 18, 2021
@lauriharpf lauriharpf self-assigned this Jul 27, 2021
lauriharpf added a commit to lauriharpf/react-native that referenced this issue Jul 27, 2021
…should come transitively, we shouldn't need a direct dependency)
dannyhw pushed a commit to raychanks/react-native that referenced this issue Feb 7, 2022
(util-deprecate should come transitively, we shouldn't need a direct dependency)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.5 bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants