Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] After opening the keyboard the android UI shrinks #211

Closed
dannyhw opened this issue Jul 12, 2021 · 2 comments · Fixed by #218
Closed

[6.0] After opening the keyboard the android UI shrinks #211

dannyhw opened this issue Jul 12, 2021 · 2 comments · Fixed by #218
Assignees
@lauriharpf
Labels
6.5 bug Something isn't working

Comments

@dannyhw
Copy link
Member

dannyhw commented Jul 12, 2021

This behaves in a strange way for me on the Android Emulator, can you reproduce it? Seems to work fine on the iOS emulator, can't reproduce the issue there.

  1. Open the story Navigator.
  2. Select the "Basic" story.
  3. Open "Addons -> Controls"
  4. Click on the "first" field so that the keyboard comes up.
  5. Click back to "Navigator"

What happens

The story list in the navigator gets truncated a lot (seems to only occupy ~50% or so of the screen) after Step 5.

Expected result

The story list would be rendered in the same way in Step 5 as it was in Step 1.

Screenshot after Step 1

Screen Shot 2021-07-11 at 20 08 59

Screenshot after Step 4

Screen Shot 2021-07-11 at 20 11 45

Screenshot after Step 5

Screen Shot 2021-07-11 at 20 13 15

Originally posted by @lauriharpf in #182 (comment)
@lauriharpf
Copy link
Contributor

@dannyhw , I could start working on this tomorrow 👍

@dannyhw dannyhw added 6.5 bug Something isn't working labels Jul 12, 2021
@dannyhw dannyhw added this to the v6 alpha 1 milestone Jul 12, 2021
@dannyhw
Copy link
Member Author

dannyhw commented Jul 12, 2021

When working on this consider just checking if the issue #41 still exists and more broadly if the changes will affect other text/number inputs that are in the preview.

@dannyhw dannyhw changed the title [6.0] After opening keyboard the android UI shrinks [6.0] After opening the keyboard the android UI shrinks Jul 12, 2021
lauriharpf added a commit to lauriharpf/react-native that referenced this issue Jul 13, 2021
@lauriharpf
fix: Fixes storybookjs#211 (After opening the keyboard the android UI…
7ad6009 
… shrinks). The steps to reproduce this issue on the Android emulator were:

0. Run the React Native examples (under examples/native) on Android
1. Open the story Navigator.
2. Select the "Basic" story.
3. Open "Addons -> Controls"
4. Click on the "first" field so that the keyboard comes up.
5. Click back to "Navigator"

## What happened
The story list in the navigator gets truncated a lot (seems to only occupy ~50% or so of the screen) after Step 5.

## What happens now after the fix
The story list doesn't get truncated; it looks the same it did after Step 1.
@lauriharpf lauriharpf mentioned this issue Jul 13, 2021
Merged
@dannyhw dannyhw linked a pull request Jul 13, 2021 that will close this issue
fix: Fixes #211 (After opening the keyboard the android UI shrinks) #218
Merged
dannyhw pushed a commit that referenced this issue Jul 13, 2021
@lauriharpf
fix: Fixes #211 After opening the keyboard the android UI shrinks
e37f3ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauriharpf lauriharpf

Labels
6.5 bug Something isn't working
Projects
React Native Storybook
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fixes #211 (After opening the keyboard the android UI shrinks) lauriharpf/react-native
2 participants
@dannyhw @lauriharpf