Merge pull request #4293 from J-Kallunki/addon-viewport-fix-iphone-vi…

…ewport-dimensions Fix #4269 iPhone viewport dimensions
storybookjs · Oct 10, 2018 · 35c45ab · 35c45ab
2 parents bda1dc0 + 6b9c5c5
commit 35c45ab
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/addons/viewport/src/manager/components/tests/Panel.test.js b/addons/viewport/src/manager/components/tests/Panel.test.js
@@ -360,7 +360,7 @@ describe('Viewport/Panel', () => {
  });
 
  it('passes the children', () => {
- expect(select.props().children).toHaveLength(15);
+ expect(select.props().children).toHaveLength(17);
  });
 
  it('onChange it updates the viewport', () => {

diff --git a/addons/viewport/src/shared/index.js b/addons/viewport/src/shared/index.js
@@ -43,16 +43,32 @@ export const INITIAL_VIEWPORTS = {
  iphone8p: {
  name: 'iPhone 8 Plus',
  styles: {
- height: '960px',
- width: '540px',
+ height: '736px',
+ width: '414px',
  },
  type: 'mobile',
  },
  iphonex: {
  name: 'iPhone X',
  styles: {
- height: '1218px',
- width: '563px',
+ height: '812px',
+ width: '375px',
+ },
+ type: 'mobile',
+ },
+ iphonexr: {
+ name: 'iPhone XR',
+ styles: {
+ height: '896px',
+ width: '414px',
+ },
+ type: 'mobile',
+ },
+ iphonexsmax: {
+ name: 'iPhone Xs Max',
+ styles: {
+ height: '896px',
+ width: '414px',
  },
  type: 'mobile',
  },