Revert "fix: defer change update for number input (#291)"

This reverts commit 1f97003.
storybookjs · Feb 7, 2022 · 2406e4e · 2406e4e
1 parent 04e30b8
commit 2406e4e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 19 deletions.
diff --git a/addons/ondevice-controls/src/PropForm.tsx b/addons/ondevice-controls/src/PropForm.tsx
@@ -1,7 +1,5 @@
-import React, { memo } from 'react';
+import React from 'react';
 import { View } from 'react-native';
-import deepEqual from 'deep-equal';
-
 import { ArgTypes } from './ControlsPanel';
 import PropField from './PropField';
 
@@ -27,8 +25,4 @@ const PropForm = ({ args, onFieldChange }: FormProps) => {
  );
 };
 
-const deepStrictEqual = (a: any, b: any): boolean => {
- return deepEqual(a, b, { strict: true });
-};
-
-export default memo(PropForm, deepStrictEqual);
+export default PropForm;
diff --git a/addons/ondevice-controls/src/types/Number.tsx b/addons/ondevice-controls/src/types/Number.tsx
@@ -26,10 +26,6 @@ export interface NumberProps {
  onChange: (value: number) => void;
 }
 
-const replaceComma = (value: number | string): string => {
- return typeof value === 'string' ? value.trim().replace(/,/, '.') : value.toString();
-};
-
 const NumberType = ({ arg, onChange = (value) => value }: NumberProps) => {
  const showError = Number.isNaN(arg.value);
  const [numStr, setNumStr] = useState(arg.value.toString());
@@ -46,7 +42,7 @@ const NumberType = ({ arg, onChange = (value) => value }: NumberProps) => {
  <Input
  autoCapitalize="none"
  underlineColorAndroid="transparent"
- value={numStr}
+ value={arg.value.toString()}
  keyboardType="numeric"
  onChangeText={handleNormalChangeText}
  style={showError && styles.errorBorder}
@@ -66,12 +62,6 @@ const NumberType = ({ arg, onChange = (value) => value }: NumberProps) => {
  );
  };
 
- useEffect(() => {
- return () => {
- onChange(numStrRef.current);
- };
- }, [onChange]);
-
  return <View style={styles.spacing}>{arg.range ? renderRange() : renderNormal()}</View>;
 };