Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): support draft 6 and 7 #576

Merged
merged 4 commits into from
Sep 20, 2019
Merged

fix(schema): support draft 6 and 7 #576

merged 4 commits into from
Sep 20, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Sep 20, 2019

Fixes #573

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

Contains 2 unrelated fixes (see commit messages).

Regarding ajv-better-errors and the exception that's thrown - I'll try to provide a fix for the package.

This is where it fails:
https://github.com/atlassian/better-ajv-errors/blob/126ee2e45ee829e69e3b2f3f6d56eb49d5c42135/src/validation-errors/enum.js#L52
https://github.com/janl/node-jsonpointer/blob/master/jsonpointer.js#L60
Basically, jsonpointer does not expect non-object value.

@P0lip P0lip added the t/bug Something isn't working label Sep 20, 2019
@P0lip P0lip added this to the Sept '19 Hardening milestone Sep 20, 2019
@P0lip P0lip self-assigned this Sep 20, 2019
OpenAPI 3.x detected

{document}
3:10 error info-title should be equal to one of the allowed values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make a feature request for adding enum values to the message? This message looks funny.

@P0lip P0lip merged commit b31450a into develop Sep 20, 2019
@P0lip P0lip deleted the fix/draft-6-and-7 branch September 20, 2019 17:41
@P0lip P0lip mentioned this pull request Sep 20, 2019
4 tasks
@P0lip P0lip removed this from the Sept '19 Hardening milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for JSON Schema Draft-06, Draft-07 and 2019-09 in schema function (rulesets)
2 participants