Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-9572] Proper building of Locutus to be friendly with container layer caching #137

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

douglascamata
Copy link

@douglascamata douglascamata commented Mar 1, 2024

  • Safe for layer caching during the container build process.
  • Adds a label with the Locutus git commit ref and tag.
    • Had to remove this because of the way images are built by the CI/CD pipelines.

Copy link

openshift-ci bot commented Mar 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Mar 1, 2024
@douglascamata
Copy link
Author

/test all

@douglascamata
Copy link
Author

/retest

@douglascamata
Copy link
Author

For the moment, blocked by containers/buildah#4974.

@douglascamata
Copy link
Author

/retest

@douglascamata
Copy link
Author

Seems like our CI is not using the Makefile to build the images anyway, so will need to think of another solution.

@douglascamata
Copy link
Author

/retest

@douglascamata douglascamata marked this pull request as ready for review March 4, 2024 10:50
@douglascamata douglascamata changed the title Proper building of Locutus with metadata tracking [ACM-9572] Proper building of Locutus to be friendly with container layer caching Mar 4, 2024
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philipgough
Copy link

/lgtm

Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [douglascamata,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 985fa56 into main Mar 5, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the track-locutus-git-ref branch March 5, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants