Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.0 #295

Merged
merged 97 commits into from
Jul 19, 2024
Merged

v1.4.0 #295

merged 97 commits into from
Jul 19, 2024

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented May 23, 2024

Description

2024-05-23

Package

  • Updated migraph logo with stocnet address, colorsafe colorway, and larger nodes and ties
  • Copied thisRequires() helper into migraph from manynet

Measures

  • All measure functions can now be used in e.g. mutate() without specifying .data

Members

  • All membership functions can now be used in e.g. mutate() without specifying .data
  • The node_member class is now categorical
    • make_node_member() now converts numeric results to LETTER character results
    • print.node_member() now works with categorical membership vectors
    • print.node_member() now declares how many groups before reporting the vectors
  • Fixed node_constraint() to work with weighted two-mode networks, thanks to Toshitaka Izumi for spotting this
  • Added network_independence() for calculating the number of nodes in the largest independent set

Motifs

  • node_tie_census() now works on longitudinal network data
  • Added to_correlation() for calculating the Pearson correlation
    • This takes a method argument for "all", "diag", "recip", or "complex"
    • These are similar to functions implemented by Ron Breiger and shared by him in correspondence
  • Fixed bug where print.node_motif() wasn't printing the requested number of lines

Models

  • Several improvements to cluster_concor()
    • cluster_concor() now uses to_correlation() for initial correlation
    • It still uses stats::cor() for subsequent iterations
    • Fixed how cluster_concor() handles unlabelled networks
    • Fixed how cluster_concor() handles two-mode networks
    • Fixed bug where cluster_concor() cutoff resulted in unsplit groups
  • cluster_hierarchical() now also uses to_correlation()

Checklist:

  • Documentation
    • Any longer functions are commented inline so that it is easier to debug in the future
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Any closed, fixed, or related issues are referenced and described, e.g. "Fixed #0 by adding A"
  • PR checks all pass for latest commit
    • Package builds on my OS without issues
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage

…ithout the diagonal and including reciprocated ties
…clares how many groups before reporting the vectors
@jhollway jhollway self-assigned this May 23, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 44.40000% with 139 lines in your changes missing coverage. Please review.

Project coverage is 49.46%. Comparing base (ce11fef) to head (4d15f50).
Report is 17 commits behind head on main.

Current head 4d15f50 differs from pull request most recent head 8137de6

Please upload reports for the commit 8137de6 to get more accurate results.

Files Patch % Lines
R/motif_census.R 48.93% 24 Missing ⚠️
R/member_community.R 52.77% 17 Missing ⚠️
R/model_cluster.R 54.83% 14 Missing ⚠️
R/measure_centrality.R 0.00% 11 Missing ⚠️
R/measure_cohesion.R 0.00% 11 Missing ⚠️
R/measure_features.R 10.00% 9 Missing ⚠️
R/measure_holes.R 10.00% 9 Missing ⚠️
R/measure_heterogeneity.R 0.00% 8 Missing ⚠️
R/measure_closure.R 0.00% 6 Missing ⚠️
R/class_members.R 33.33% 4 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   50.76%   49.46%   -1.31%     
==========================================
  Files          25       27       +2     
  Lines        2147     2347     +200     
==========================================
+ Hits         1090     1161      +71     
- Misses       1057     1186     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@henriquesposito henriquesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the work @jhollway , the new logo looks great!

…enerate_random() instead of the original object, which is processed more intuitively within manynet::generate_random() (thanks @RWKrause)
… that it includes best practice in terms of specification
@jhollway jhollway merged commit 74b8590 into main Jul 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants