Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32F1 merge other (BluePill and Maple Mini) #61

Closed
wants to merge 11 commits into from
Closed

STM32F1 merge other (BluePill and Maple Mini) #61

wants to merge 11 commits into from

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jul 11, 2017 •
edited

Second part of the Arduino_Core_STM32F1 merge. #20 --> now covered by #213 except for USB part

Include above variant from #45

  • BLUEPILL-F103C8
  • MAPLEMINI-F103CB

Need some review around USB (based on contributor feedback)
Need review upload menu (avoid maple one for BP) Covered by #213
...

@fpistm fpistm mentioned this pull request Jul 11, 2017
Closed
@fpistm fpistm force-pushed the STM32F1_merge_Other branch 2 times, most recently from 93d8db4 to addd3ea Compare July 12, 2017 14:44
@fpistm fpistm changed the title STM32F1 merge other (BluePill Maple Mini and and STM32F1VLDisco STM32F1 merge other (BluePill Maple Mini and and STM32F1VLDisco) Jul 12, 2017
@fpistm fpistm added enhancement New feature or request help wanted 🙏 Extra attention is needed labels Jul 12, 2017
@fpistm fpistm requested a review from a user July 12, 2017 14:45
@fpistm fpistm assigned fpistm and ghost Jul 12, 2017
@fpistm fpistm changed the title STM32F1 merge other (BluePill Maple Mini and and STM32F1VLDisco) STM32F1 merge other (BluePill Maple Mini and) Aug 2, 2017
@fpistm fpistm changed the title STM32F1 merge other (BluePill Maple Mini and) STM32F1 merge other (BluePill and Maple Mini) Aug 2, 2017
@fpistm fpistm force-pushed the STM32F1_merge_Other branch 3 times, most recently from 40275c7 to c7678b9 Compare August 21, 2017 15:08
@RickKimball
Copy link
Contributor

So I'm looking at this new branch and it doesn't seem like any of the USB issues I mentioned in #45 have been addressed. Is this something that is being looked at?

@RickKimball
Copy link
Contributor

BTW: The default upload method of "Maple bootloader" is probably a bad pick for the Other boards. Most people are using a bluepill according to the latest Poll on stm32duino. Even those who are using a maple mini typically update the bootloader to the latest one because it is smaller in flash size and works better in general.

@fpistm
Copy link
Member Author

fpistm commented Aug 23, 2017

@RickKimball, it's ongoing, they are lot of work/review around USB and this need some time. As you can see, I've rebased regularly this PR.
About the bootloader, you talk about the fact BP has the Maple bootloader in the menu ?
It is plaaned to split Other menu to be able to have correct upoad method and also be able to have some customization as asked in #59

@fpistm fpistm force-pushed the STM32F1_merge_Other branch 2 times, most recently from 0216236 to f85ebb5 Compare August 30, 2017 14:39
@fpistm fpistm added this to the Next release milestone Aug 31, 2017
fpistm and others added 8 commits September 1, 2017 10:29
@fpistm
BluePill F103C8 variant added.
e737f89 
Upload method Bootloader, Serial and BMP added.
USBSerial class added because is required by bootloader.

Signed-off-by: fpr <[email protected]>
@fpistm
Maple Mini STM32F103CB added.
69c09fb 
Signed-off-by: fpr <[email protected]>
@fpistm
Aligns configuration with master
5ef765c 
Signed-off-by: fpr <[email protected]>
@fpistm
Add extra include path for USB CDC
1902beb 
Signed-off-by: fpr <[email protected]>
@fpistm
Add USB IRQHandler for BluePill and MapleMini variants
47ca5c2 
Signed-off-by: fpr <[email protected]>
@fpistm
BluePill pin mapping reordered
f3b6c46 
Signed-off-by: fpr <[email protected]>
@fpistm
Add missing {build.upload_flags}
dc7f4d5 
Signed-off-by: Frederic.Pillon <[email protected]>
@fpistm
Align Pins name and pins index after merged of stm32duino#83
6ec7b0b 
Signed-off-by: Frederic.Pillon <[email protected]>
ghost
ghost reviewed Sep 19, 2017
View reviewed changes
boards.txt
Other.menu.upload_method.STLinkMethod=STLink
Other.menu.upload_method.STLinkMethod.upload.protocol=STLink
Other.menu.upload_method.STLinkMethod.upload.tool=stlink_upload
Other.menu.upload_method.STLinkMethod.build.upload_flags=-DSERIAL_USB
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move STLink method before DFUUploadMethod. STLink will be the default Upload method.

variants/MAPLEMINI_F103CB/variant.h
#define SS3 10
#define MOSI 6
#define MISO 5
#define SCK 4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPI configuration should be updated.

@Testato
Copy link
Contributor

Testato commented Dec 4, 2017 •
edited

@cparata
this is the issue we talked about at the Maker Faire Rome 2017.

The official merge of Bluepill (and all the classic board with F103C8 / CB) is of vital importance given the commercial success of these boards, all the users of Roger's core have a Bluepill / Maplemini at home

Official support for Bluepill has been mentioned for some time in the core homepage, but never merged.
https://github.com/stm32duino/Arduino_Core_STM32#next-release

@fpistm fpistm mentioned this pull request Dec 4, 2017
Closed
@lacklustrlabs
Copy link
Contributor

I have successfully tested this with maple mini + STLink and I would love to see this merged.
If there is a problem with USB, couldn't that be added/fixed at a later stage?

@fpistm
Copy link
Member Author

fpistm commented Jan 12, 2018

I'm currently thinking to add BP and MM without USB support.
And as you mentioned review USB later so only STLink upload and Serial via a FTDI will be available.

lacklustrlabs added a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 19, 2018
@lacklustrlabs
Temporary quick and dirty rebase of stm32duino#61, Blinky with serial…
515fb5a 
… works on a maple mini (STLink upload, UART2).
lacklustrlabs added a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 23, 2018
@lacklustrlabs
Temporary quick and dirty rebase of stm32duino#61, Blinky with serial…
66b2359 
… works on a maple mini (STLink upload, UART2).
lacklustrlabs added a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 29, 2018
@lacklustrlabs
stm32duino#61 Rebased. MM & BP blinky tested with STLink and Serial2
8a35b47
@fpistm
Copy link
Member Author

fpistm commented Jan 30, 2018 •
edited

I will provide the light version end of the week.

@fpistm fpistm added new variant Add support of new bard and removed enhancement New feature or request labels Jan 31, 2018
@lacklustrlabs
Copy link
Contributor

Feel free to copy&paste from my temporary BP&MM rebase branch. I think I was too heavy handed with the USB stuff so I won't make a PR with it.

@fpistm fpistm mentioned this pull request Jan 31, 2018
Merged
@fpistm fpistm added abandoned No more work on this and removed help wanted 🙏 Extra attention is needed labels Jan 31, 2018
@fpistm fpistm removed this from the Next release milestone Feb 1, 2018
@fpistm fpistm mentioned this pull request Mar 6, 2018
Closed
2 tasks
@fpistm fpistm closed this Mar 6, 2018
@fpistm fpistm deleted the STM32F1_merge_Other branch May 29, 2019 14:23
@fpistm fpistm mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@fpistm fpistm

Labels
abandoned No more work on this new variant Add support of new bard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fpistm @RickKimball @Testato @lacklustrlabs