Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move several sources as built-in library #2404

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jun 19, 2024

Several reasons:

  • Avoid licenses conflict
  • Improve build time on windows
  • 1 feature per library

@fpistm fpistm added this to the 2.8.0 milestone Jun 19, 2024
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Jun 19, 2024
@fpistm fpistm force-pushed the refactor_code branch 2 times, most recently from f30df88 to 349e313 Compare June 19, 2024 14:14
Copy link
Contributor

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
A few comments:

License.md Outdated Show resolved Hide resolved
License.md Outdated Show resolved Hide resolved
License.md Outdated Show resolved Hide resolved
libraries/VirtIO/src/VirtIO.h Outdated Show resolved Hide resolved
libraries/USBDevice/examples/BareMinimum/BareMinimum.ino Outdated Show resolved Hide resolved
libraries/USBDevice/library.properties Outdated Show resolved Hide resolved
libraries/VirtIO/library.properties Outdated Show resolved Hide resolved
belong to sources.

Signed-off-by: Frederic Pillon <[email protected]>
Including OpenAMP.

Signed-off-by: Frederic Pillon <[email protected]>
It could propbaly be splitted in 3 libraries:
	- USBDevice: base support
	- USBDCDC
	- USBDHID

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm merged commit a3e468a into stm32duino:main Jun 20, 2024
24 checks passed
STM32 core based on ST HAL automation moved this from In progress to Done Jun 20, 2024
@fpistm fpistm deleted the refactor_code branch June 20, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants