Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Blues Cygnet #2399

Merged
merged 3 commits into from
Jun 14, 2024
Merged

feat: Blues Cygnet #2399

merged 3 commits into from
Jun 14, 2024

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Jun 12, 2024 •
edited
Loading

Refactor Blues Wireless to Blues
Define Cygnet
Improvements to Swan

The bad link (in the checks), is our reserved page for this product.

@zfields
Copy link
Contributor Author

zfields commented Jun 12, 2024

This migrates the Ray's original Cygnet work to the STM32L433CCT6, and incorporates many suggestions from @fpistm's code review.

@fpistm Can you please sanity check this work. This is my first time making significant modifications to the board definition.

@fpistm fpistm self-requested a review June 13, 2024 06:48
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Jun 13, 2024
fpistm
fpistm requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zfields
Thanks for the updated PR.
Just on remarks about the link even if reserved on your side I would prefer add it when really available to avoid further support because one link does not exist and not related to other PR.

README.md Outdated Show resolved Hide resolved
tools/platformio/boards_remap.json Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review Jun 13, 2024
@zfields
Copy link
Contributor Author

zfields commented Jun 13, 2024

@fpistm I've adopted your change. 👍 Thank you for your help! ❤️

@fpistm fpistm self-requested a review June 14, 2024 06:56
@fpistm fpistm added this to the 2.8.0 milestone Jun 14, 2024
fpistm
fpistm approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zfields
I've squash some commits to be more clean.
LGTM

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Jun 14, 2024
@fpistm fpistm merged commit 7efecbf into stm32duino:main Jun 14, 2024
24 checks passed
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Jun 14, 2024
@zfields zfields deleted the cygnet branch June 14, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
New variant
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zfields @fpistm