Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32H7B0VBTX board variant added to the boards #2387

Merged
merged 15 commits into from
Jun 5, 2024

Conversation

Aurentiaco35
Copy link
Contributor

I added this variant and tested everyhing works like expected for STM32H7B0VBT. I tested specificly for STM32H7B0VBT in my project but I added the other boards like in Add a new vatiant wiki. Please update the wiki the memory part should not updated like in wiki otherwise it is not working because of cortex m7 it need partial memories.

I added this variant and tested everyhing works like expected for STM32H7B0VBT. I tested specificly for STM32H7B0VBT in my project but I added the other boards like in Add a new vatiant wiki. Please update the wiki the memory part should not updated like in wiki otherwise it is not working because of cortex m7 it need partial memories.
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Aurentiaco35
Thanks for the PR.
About the Size in linker script, it should simply refers to the one defined in the boards.txt.
Then all generic variants have the correct value and can benefit of the offset feature.
In the boards.txt, the value of the RAM have to be updated to match the correct size used for Arduino, mainly when it is not contiguous.
The wiki, show a simple use case where only 1 FLASH and 1 RAM section are described.
Even the linker script can be updated, for example when RAM's are contiguous then only one with the full size can be defined.

README.md Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Jun 3, 2024
@fpistm fpistm added this to the 2.8.0 milestone Jun 3, 2024
Aurentiaco35 and others added 12 commits June 3, 2024 16:33
Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
…t.ld

Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
…t.ld

Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
…_clock.c

Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
…_clock.c

Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
…_clock.c

Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Aurentiaco35 <[email protected]>
@Aurentiaco35
Copy link
Contributor Author

I commited these suggestions. Thank you for your help.

@Aurentiaco35 Aurentiaco35 requested a review from fpistm June 4, 2024 06:51
I added space character as it in the test error 

Signed-off-by: Aurentiaco35 <[email protected]>
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from In progress to Reviewer approved Jun 4, 2024
@Aurentiaco35
Copy link
Contributor Author

I couldn't understand in that linkintor which part should I update?

@fpistm
Copy link
Member

fpistm commented Jun 4, 2024

Nothing. The url probably down during the test.

@Aurentiaco35
Copy link
Contributor Author

Aurentiaco35 commented Jun 4, 2024

So what should I do next is there anything that I can do? When you are going to merge and we will see these boards in IDE?

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the last issue and squash all commit in one.

boards.txt Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from Reviewer approved to Needs review Jun 4, 2024
@fpistm
Copy link
Member

fpistm commented Jun 4, 2024

And don't worry, I will merge it when last changes performed then it will be available within next release 2.8.0.

Signed-off-by: Aurentiaco35 <[email protected]>
@Aurentiaco35
Copy link
Contributor Author

Thank you for your info. And sorry about it. I missed that now I commit it. Thank you again.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Jun 4, 2024
@fpistm fpistm merged commit 483c954 into stm32duino:main Jun 5, 2024
24 checks passed
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants