Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use PA6 as analog input with a NUCLEO-H743ZI2 #1277

Closed
pierremolinaro opened this issue Jan 12, 2021 · 2 comments · Fixed by #1091
Closed

Cannot use PA6 as analog input with a NUCLEO-H743ZI2 #1277

pierremolinaro opened this issue Jan 12, 2021 · 2 comments · Fixed by #1091
Labels
enhancement New feature or request
Projects
STM32 core based on ST HAL
Milestone
2.0.0

Comments

@pierremolinaro
Copy link

  • OS: Mac OS X
  • Arduino IDE version: 1.8.13
  • STM32 core version: 1.9.0
  • Board Name: NUCLEO-H743ZI2

Describe the bug
I try to use PA6 as analog input. Calling analogRead (PA6) returns always zero.

Bug Fix
I think the bug is in the ~/Library/Arduino15/packages/STM32/hardware/stm32/1.9.0/variants/NUCLEO_H743ZI/PeripheralPins.c file.

Line 57 {PA_6, ADC1, STM_PIN_DATA_EXT(STM_MODE_ANALOG, GPIO_NOPULL, 0, 3, 0)}, // ADC1_INP3 is commented.

Uncommenting this line solves the bug.

Best regards,

Pierre Molinaro
@fpistm
Copy link
Member

fpistm commented Jan 12, 2021

Hi @pierremolinaro

In this case this is not a bug. The variant has been described like this.
Anyway with #1091 this will be changed as all pins would be available.

@pierremolinaro
Copy link
Author

Ok, thank you very much for your answer.

Best regards,

Pierre Molinaro

@fpistm fpistm added this to the 2.0.0 milestone Jan 20, 2021
@fpistm fpistm added this to To do in STM32 core based on ST HAL via automation Jan 20, 2021
@fpistm fpistm added the enhancement New feature or request label Jan 20, 2021
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Feb 12, 2021
@fpistm
[variant] Update Generic H7xx
c225c81 
Fixes stm32duino#1276 and stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm mentioned this issue Feb 15, 2021
Merged
27 tasks
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Feb 17, 2021
@fpistm
[variant] Update Generic H7xx
7da49e0 
Fixes stm32duino#1276 and stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 15, 2021
@fpistm
[variant] Update Generic H7xx
30e541c 
Fixes stm32duino#1276 and stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 16, 2021
@fpistm
[variant] Update Generic H7xx
ade0a1e 
Fixes stm32duino#1276 and stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
valeros pushed a commit to valeros/Arduino_Core_STM32 that referenced this issue Mar 16, 2021
@fpistm @valeros
Update Generic H7xx
0b3a6ff 
Fixes stm32duino#1276 and stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 22, 2021
@fpistm
[variant] Update Generic H7xx
33b8067 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 23, 2021
@fpistm
[variant] Update Generic H7xx
a0edfc5 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 24, 2021
@fpistm
[variant] Update Generic H7xx
9526f17 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 24, 2021
@fpistm
[variant] Update Generic H7xx
8ea306a 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 24, 2021
@fpistm
[variant] Update Generic H7xx
4084c6a 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 28, 2021
@fpistm
[variant] Update Generic H7xx
ab84015 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 29, 2021
@fpistm
[variant] Update Generic H7xx
c7477fb 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 30, 2021
@fpistm
[variant] Update Generic H7xx
7ff309a 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 30, 2021
@fpistm
[variant] Update Generic H7xx
421d9c7 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Mar 30, 2021
@fpistm
[variant] Update Generic H7xx
92d4a22 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 2, 2021
@fpistm
[variant] Update Generic H7xx
ef34714 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 8, 2021
@fpistm
[variant] Update Generic H7xx
97a7e43 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 9, 2021
@fpistm
[variant] Update Generic H7xx
5e4d882 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 9, 2021
@fpistm
[variant] Update Generic H7xx
470548d 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 9, 2021
@fpistm
[variant] Update Generic H7xx
1c1f1ac 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 12, 2021
@fpistm
[variant] Update Generic H7xx
79d714e 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 14, 2021
@fpistm
[variant] Update Generic H7xx
d7f94e5 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 15, 2021
@fpistm
[variant] Update Generic H7xx
bf60740 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 15, 2021
@fpistm
[variant] Update Generic H7xx
4f033ba 
Fix stm32duino#1276 and Fix stm32duino#1277

Signed-off-by: Frederic Pillon <[email protected]>
STM32 core based on ST HAL automation moved this from To do to Done Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

[variant] Improve variant support and genericity fpistm/Arduino_Core_STM32
2 participants
@pierremolinaro @fpistm