Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USER_BTN mapping to PA0 for BlackPill F401CC/F401CE boards #1144

Closed
pawelsky opened this issue Aug 15, 2020 · 4 comments · Fixed by #1091
Closed

Add USER_BTN mapping to PA0 for BlackPill F401CC/F401CE boards #1144

pawelsky opened this issue Aug 15, 2020 · 4 comments · Fixed by #1091
Assignees
Milestone

Comments

@pawelsky
Copy link

Since v1.2 BlackPill F401CC/F401CE boards have an user button (named "KEY") connected to PA0 added to the board. You can find more details about this board here

Please add the USER_BTN define mapping to PA0 for BlackPill F401CC and the proposed F401CE boards. That would be consistent with the already existing BlackPill F411CE USER_BTN mapping

I believe the following change in the Generic_F401Cx/variant.h file should do the job:

// On-board user button
#if defined(ARDUINO_BLACKPILL_F401CC) || defined(ARDUINO_BLACKPILL_F401CE)
#define USER_BTN PA0
#elif !defined(USER_BTN) && !defined(ARDUINO_GENERIC_F401CC)
#define USER_BTN PC13
#endif

@ABOSTM
Copy link
Contributor

ABOSTM commented Apr 2, 2021

Hi @pawelsky,
The BlackPill F401CC doesn't have KEY button.
The BlackPill F401CE have the button but this board is not yet supported.
So this issue correspond to the request to support BlackPill F401CE and thus is duplicate of #1143
BlackPill F401CE has already been add to the request list #722.
This is a community project, so any contribution to add this board is welcome (even if I would suggest to way for PR1091 to be merged first).
Thus I close this issue.

@ABOSTM ABOSTM closed this as completed Apr 2, 2021
@pawelsky
Copy link
Author

pawelsky commented Apr 2, 2021

Hi @ABOSTM

There are revisions of F401CC that do have the key (photo of v3.0 attached), so I'd request this issue to be reopened.

STM32F401CCU6_with_key

ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this issue Apr 2, 2021
Note this user buuton is not available on all revisions of this board

Fixes stm32duino#1144
@ABOSTM
Copy link
Contributor

ABOSTM commented Apr 2, 2021

Ok I was not aware of this change in latest board revision.
Even if it could be considered as a different board, we decided to consider only 1 board in which USER_BTN is defined,
even if user button is only available on some board revisions.
It is implemented there:
fpistm@72dd95f
And it will be part of #1091
(thus no need to reopen this issue)

@pawelsky
Copy link
Author

pawelsky commented Apr 2, 2021

That makes sense. Thanks!

@fpistm fpistm added this to the 2.0.0 milestone Apr 2, 2021
@fpistm fpistm added this to To do in STM32 core based on ST HAL via automation Apr 2, 2021
@fpistm fpistm moved this from To do to Done in STM32 core based on ST HAL Apr 2, 2021
@fpistm fpistm linked a pull request Apr 2, 2021 that will close this issue
27 tasks
ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this issue Apr 2, 2021
Note this user buuton is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this issue Apr 2, 2021
Note this user buuton is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this issue Apr 2, 2021
Note this user buuton is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this issue Apr 6, 2021
Note this user buuton is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this issue Apr 6, 2021
Note this user buuton is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 12, 2021
Note this user button is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 13, 2021
Note this user button is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 14, 2021
Note this user button is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 14, 2021
Note this user button is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 14, 2021
Note this user button is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 15, 2021
Note this user button is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 15, 2021
Note this user button is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this issue Apr 16, 2021
Note this user button is not available on all revisions of this board

Fixes stm32duino#1144

Signed-off-by: Alexandre Bourdiol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants