getActiveTransactionId(String chargeBox, Integer connectorId) method,…

… add .orderBy(TRANSACTION.TRANSACTION_PK.desc()) to avoid fetching ghost transactions, fetch the latest

src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java

@@ -65,6 +65,16 @@ public TransactionRepositoryImpl(DSLContext ctx) {
  this.ctx = ctx;
  }
 
+ @Override
+ public Transaction getTransaction(int transactionPk) {
+ TransactionQueryForm form = new TransactionQueryForm();
+ form.setTransactionPk(transactionPk);
+ form.setReturnCSV(false);
+ form.setType(TransactionQueryForm.QueryType.ALL);
+ return getInternal(form).fetch()
+ .map(new TransactionMapper()).get(0);
+ }
+
  @Override
  public List<Transaction> getTransactions(TransactionQueryForm form) {
  return getInternal(form).fetch()
@@ -97,19 +107,10 @@ public Integer getActiveTransactionId(String chargeBoxId, Integer connectorId) {
  .and(CONNECTOR.CHARGE_BOX_ID.equal(chargeBoxId))
  .where(TRANSACTION.STOP_TIMESTAMP.isNull())
  .and(CONNECTOR.CONNECTOR_ID.equal(connectorId))
+ .orderBy(TRANSACTION.TRANSACTION_PK.desc()) // to avoid fetching ghost transactions, fetch the latest
  .fetchAny(TRANSACTION.TRANSACTION_PK);
  }
 
- @Override
- public String getOcppTagOfTransaction(Integer transactionPk) {
- return ctx.select(TRANSACTION.ID_TAG)
- .from(TRANSACTION)
- .where(TRANSACTION.TRANSACTION_PK.eq(transactionPk))
- .fetchAny(TRANSACTION.ID_TAG);
- /* .fetch().sortDesc(TRANSACTION.START_TIMESTAMP).getValue(0, TRANSACTION.ID_TAG);
- if TRANSACTION has sometimes errors an more then one open/active transaction per connector */
- }
-
  @Override
  public TransactionDetails getDetails(int transactionPk, boolean firstArrivingMeterValueIfMultiple) {