Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from single user (config) to database based multi user system. #1165

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Change from single user (config) to database based multi user system. #1165

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ae0d9d2
Change from single user (config) to database based multi user system.
Jun 2, 2023
61e3f00
style checks
Jun 2, 2023
7a15857
delete noAccessController to rename
Jun 2, 2023
9d84a5a
add renamed NoAccessController
Jun 2, 2023
1359cc8
style check
Jun 2, 2023
cc3db61
Removed out commented code; cleaned the import areas, removed useless…
Jun 3, 2023
4f51fc3
Increased spring-boot version to 3.1.0
Jun 3, 2023
45d9ab3
Revert Commit, because not Java 11 compatible
Jun 3, 2023
7aa3bd6
adding missing newline at the file end (style check)
Jun 3, 2023
6564cdc
WebUserController: correct return url if passwort is blank
Jun 5, 2023
edd2365
BeanConfiguration: added @Autowired to HikariDataSource and @Bean to …
Jun 5, 2023
778318f
SecurityConfiguration: changed DataSource to HikariDataSource and add…
Jun 5, 2023
fa7a2fc
pom.xml: revomed dependency of org.springframework.boot and moved dep…
Jun 5, 2023
54e7198
BeanConfiguration: initDataSource returns the new HikariDataSourcedir…
Jun 5, 2023
98b9ce8
BeanConfiguration: renamed initDataSource() --> dataSource(); removed…
Jun 6, 2023
040878c
NoAccessController: removed the RequestMethod, so all requests can be…
Jun 6, 2023
647ca1c
SecurityConfiguration: adapt SecurityFilterChain, so Usesr have "read"
Jun 6, 2023
42980df
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Nov 28, 2023
0236b55
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Dec 13, 2023
0276925
Rename db migration script to avoid conflict with master. Included if…
Dec 24, 2023
bd62f19
Rename db migration script removed "if not exist" clauses because of …
Dec 24, 2023
2f67258
Merge db migration script V1_0_4 from master
Dec 24, 2023
6fde7dc
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Dec 24, 2023
d2273f7
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Jan 15, 2024
4a7a616
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Feb 1, 2024
ab84315
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Feb 6, 2024
ed4e602
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Feb 19, 2024
6a6c96a
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Mar 28, 2024
a3d6d16
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Apr 3, 2024
a3f2fd2
Merge branch 'steve-community:master' into MultiUsers
fnkbsi Apr 19, 2024
291f683
Merge branch 'steve-community:master' into MultiUsers
fnkbsi May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Increased spring-boot version to 3.1.0
  • Loading branch information
fnkbsi authored and fnkbsi committed Jun 3, 2023
commit 4f51fc36cacb5332ec125e7921dc598d16bb16fe
3 changes: 1 addition & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,13 +775,12 @@
<dependency>
<groupId>org.springframework.boot</groupId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks the 2 new dependencies are not used. They should be removed IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both dependencies used in SecurityConfiguration.java
by "import org.springframework.boot.jdbc.DataSourceBuilder;" (line 55)

Copy link
Member

@goekay goekay Jun 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

steve is not using spring boot though. it is a spring app, not a spring boot app.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fnkbsi steve uses jooq for the data access. You should be able to replace spring-jdbc by that. Then no need to datasourcebuilder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goekay any feedback about the feature itself?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i find the feature very valuable, but need time to to review the code. at a glance, i find that the implementation needs some tidying up which is already happening. thanks @fnkbsi

<artifactId>spring-boot</artifactId>
<version>2.1.5.RELEASE</version>
<version>3.1.0</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-jdbc</artifactId>
<!--<version>5.3.18</version>-->
<type>jar</type>
</dependency>
</dependencies>
Expand Down
Loading