Abort task on error #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why remove the commas? Having them there makes it easier to cut and paste lines without having to adjust commas and reduces risk of missing comma errors. Like the Grunt example code here, all trailing commas: http:https://gruntjs.com/configuring-tasks |
|
You are right. JSHint throws an error. But it is related for browser environment. |
|
What about this PR - Nice improvement |
|
Agreed :), apologies for the delay in acting on this on. Thanks @alexVauch & @Aetles |
stephenharris
added a commit
that referenced
this pull request
Mar 30, 2015
Abort task on error. Props to @alexVauch.
|
Published. I've also added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. it's better to abort task on text domain errors. It is necessary when using batch of tasks.