Fix/windows loader names #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates regex to match forward and backward slashes (*nix and Windows convention) and normalizes Windows file-system backslashes to forward slashes.
Updates regex to match forward and backward slashes (*nix and Windows convention) and normalizes Windows file-system backslashes to forward slashes.
|
Thanks for raising this PR :) This looks really good - I'll try and release this later today |
|
You're welcome. :) |
|
Thanks so much for this PR @rjgotten! Sorry for the huge delay in actually getting round to this 😫 I was actually testing this today, and it looks like it has a few syntax issues with the regex... I've got a similar fix, though, in efda81b, which will be going out shortly 🙂 I'll close this for now — but thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #84
Also; consistently applies the fix for scoped packages, which was missing from one of the regexes.