Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proxy readonly deprecated hooks error in webpack 5 #152

Merged
merged 2 commits into from
Jan 23, 2021
Merged

fix proxy readonly deprecated hooks error in webpack 5 #152

merged 2 commits into from
Jan 23, 2021

Conversation

tanhauhau
Copy link
Contributor

Fixes #149

rmariuzzo
rmariuzzo suggested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@rmariuzzo rmariuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small change.

__tests__/setups/v5-deprecated-hooks/package.json Outdated Show resolved Hide resolved
@brybrophy
Copy link

@rmariuzzo @simPod Can we get this merged, please? This is blocking my team from being able to upgrade to webpack 5.

@stephencookdev
Copy link
Owner

Nice, this looks great — awesome stuff @tanhauhau! I'll merge this into the upcoming 1.4.0 release :)

@stephencookdev stephencookdev changed the base branch from master to release/1.4.0 January 23, 2021 15:50
@stephencookdev stephencookdev merged commit 12cc3f4 into stephencookdev:release/1.4.0 Jan 23, 2021
@tanhauhau tanhauhau deleted the tanlh/fix-frozen-deprecated-hooks branch January 26, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmariuzzo rmariuzzo rmariuzzo requested changes

@simPod simPod simPod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does it work with webpack 5?
5 participants
@tanhauhau @brybrophy @stephencookdev @simPod @rmariuzzo