Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make sure maintain the same referential equality even after using proxy #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix make sure maintain the same referential equality even after using…
… proxy
  • Loading branch information
tanhauhau committed Nov 26, 2020
commit e2b769cfc0076a4ce34bd9ae22bd2d8e8ef2f746
6 changes: 6 additions & 0 deletions WrappedPlugin/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
let idInc = 0;

const weakMap = new WeakMap();

const genWrappedFunc = ({
func,
smp,
Expand Down Expand Up @@ -200,6 +202,8 @@ const wrap = (orig, pluginName, smp, addEndEvent) => {
return orig.apply(this, arguments);
}
: orig;
} else if (weakMap.has(orig)) {
return weakMap.get(orig);
} else {
const proxy = new Proxy(orig, {
get: (target, property) => {
Expand Down Expand Up @@ -247,6 +251,8 @@ const wrap = (orig, pluginName, smp, addEndEvent) => {
},
});

weakMap.set(orig, proxy);

wrappedReturn = proxy;
}

Expand Down
Loading