Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow rules with loader+options combination (useEntry) #120

Merged

Conversation

ZauberNerd
Copy link
Contributor

Sometimes loaders can have only loader and options property which breaks in the current setup because the prependLoader function will only take the loader and put it as a string into the rules.use array.
This PR addresses this issue and will add an object with loader and options to the use array if options is present.

See also useEntry in webpack docs.

@stephencookdev
Copy link
Owner

Awesome! Thanks for the fix @ZauberNerd! I'll merge this into the upcoming 1.4.0 release

@stephencookdev stephencookdev changed the base branch from master to release/1.4.0 January 23, 2021 16:20
@stephencookdev stephencookdev merged commit c8a2d75 into stephencookdev:release/1.4.0 Jan 23, 2021
@ZauberNerd ZauberNerd deleted the fix-useentry-shorthand branch January 23, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants