Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/loader build time comparison #119

Conversation

The-Only-Matrix
Copy link
Contributor

This option gives you per loader module count, module time to execute, time comparison
with previous build of each loader. It stores current and previous build info in the file path given by user and it also allows user to commit the file containing build info into git version control system. But user can see the output of all builds in the terminal only.

Usage :-

const smp = new SpeedMeasurePlugin({
  compareLoadersBuild: { filePath: "./buildInfo.json", commitBuildInfo: true },
});

Screenshot 2020-04-15 at 6 13 55 PM

Screenshot 2020-04-15 at 6 15 42 PM

@stephencookdev
Copy link
Owner

awesome stuff @The-Only-Matrix :D This looks great, thanks for raising it

I have a concern about the part of this PR where we git push etc., it feels like it's overstepping the boundaries of this plugin.

What do you think about keeping the output formatting of this PR (which is great), and just removing the part that automates the committing and pushing of the generated file? I think we could make it a lot more flexible to peoples' use-cases by just adding some docs on how to do the same thing themselves with some documentation/code-snippets of a Husky/Travis setup or something.

@The-Only-Matrix
Copy link
Contributor Author

The-Only-Matrix commented Feb 5, 2021

awesome stuff @The-Only-Matrix :D This looks great, thanks for raising it

I have a concern about the part of this PR where we git push etc., it feels like it's overstepping the boundaries of this plugin.

What do you think about keeping the output formatting of this PR (which is great), and just removing the part that automates the committing and pushing of the generated file? I think we could make it a lot more flexible to peoples' use-cases by just adding some docs on how to do the same thing themselves with some documentation/code-snippets of a Husky/Travis setup or something.

@stephencookdev - Agreed with the above point and have updated changes. Thanks

suraj.patel and others added 4 commits February 5, 2021 15:41
Merge branch 'feature/loader-build-time-comparison' of github.com:The-Only-Matrix/speed-measure-webpack-plugin into feature/loader-build-time-comparison
@stephencookdev stephencookdev changed the base branch from master to release/1.5.0 March 28, 2021 11:01
@stephencookdev stephencookdev merged commit d2db216 into stephencookdev:release/1.5.0 Mar 28, 2021
sunft1996 pushed a commit to sunft1996/speed-measure-webpack-plugin-source-read that referenced this pull request Jul 20, 2023
…ader-build-time-comparison

Feature/loader build time comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants