Add flag for stanc3 #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I'm closing this PR as we're implementing the fix through rstantools, so no changes to your package will be necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a compiler flag to your
Makevarsfiles which is needed for compatibility with the upcoming version ofrstan:-DUSE_STANC3The Stan-to-c++ transpiler (
stanc) was refactored after 2.21, and so different c++ is used in the newrstanpackage (>= 2.26). Because of this, the flag-DUSE_STANC3needs to be added when a stan model is being run using the new rstan package (and the new stanc implementation).This PR adds the compiler flag, which is conditionally set based on the installed
rstanversion.Feel free to let me know if you need any more info.
Thanks!
Andrew