Offers schema 9 #972
Merged
Offers schema 9 #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2019
tomquisel
approved these changes
Mar 7, 2019
| newOffers[i] = offer | ||
|
|
||
| var sellingAssetCode, sellingIssuer string | ||
| err = sellingAsset.Extract( |
There was a problem hiding this comment.
It seems unfortunate to do this Extract to create a db2/core:Offer object, only to convert it to a horizon:Offer object later (in PopulateOffer). What about modifying the db Offer object to hold xdr.Assets?
There was a problem hiding this comment.
Really great suggestion! Simplifies a lot (code, tests, readability), thanks!
| @@ -18,15 +18,20 @@ func (q *Q) SignersByAddress(dest interface{}, addy string) error { | |||
| return q.Select(dest, sql) | |||
| } | |||
|
|
|||
| var signersXDRString string | |||
| var signersXDRString *string | |||
There was a problem hiding this comment.
Good fix, although I'd split into two PRs in the future.
tomquisel
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
offertable queries to use new Core DB schema 9 (stellar/stellar-core#1957). It also fixesSignersByAddressto supportNULLvalues (close #967).I wasn't able to test it using the code in stellar/stellar-core#1957 because it doesn't automatically upgrade the DB schema. Will test it once it's merged.EDIT: confirmed. It wasn't upgrading because of a mistake in my config file.