Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horizon/integration/test: added test for reingest with --ledgerbackend datastore #5383

Merged
merged 14 commits into from
Jul 12, 2024
Merged

horizon/integration/test: added test for reingest with --ledgerbackend datastore #5383

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c8fd26e
#4911: added reingest cmd integration test for datastore ingest
sreuland Jul 10, 2024
3e8efb2
#4911: added integration test for db reingest with --ledgerbacked dat…
sreuland Jul 11, 2024
337006c
#4911: removed test debug lines
sreuland Jul 11, 2024
a19e929
#4911: cleaned up go.mod tidy
sreuland Jul 11, 2024
ee50449
#4911: fixed govet warning
sreuland Jul 11, 2024
bbe931d
#4911: fixed test reusage of commands, reset args
sreuland Jul 11, 2024
5d89697
#4911: reset command args after each cmd invoke in db cmd tests
sreuland Jul 11, 2024
07337a5
#4911: added ResetCmds() for tests to redefine cobra commands to re e…
sreuland Jul 12, 2024
cd15f6b
#4911: avoid rootcmd arg/flag state collisions during test usages
sreuland Jul 12, 2024
70d8098
Merge remote-tracking branch 'upstream/reingest_precomputed' into rei…
sreuland Jul 12, 2024
9981bac
#4911: use rootcmd instance not package singleton in tests
sreuland Jul 12, 2024
a3c452e
#4911: use flag config instance not global for test root cmd execution
sreuland Jul 12, 2024
50fef11
#4911: use root cmd instance not package var for reingest parallel test
sreuland Jul 12, 2024
b1573d0
#4911: use root cmd instance not package var for migrate tests
sreuland Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#4911: use rootcmd instance not package singleton in tests
  • Loading branch information
@sreuland
sreuland committed Jul 12, 2024
commit 9981bac99f5be78a5efb148d07f0fd156c69f130
24 changes: 5 additions & 19 deletions services/horizon/cmd/db_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,6 @@ type DBCommandsTestSuite struct {
rootCmd *cobra.Command
}

func (s *DBCommandsTestSuite) SetupTest() {
resetFlags()
}

func resetFlags() {
RootCmd.ResetFlags()
dbFillGapsCmd.ResetFlags()
dbReingestRangeCmd.ResetFlags()

globalFlags.Init(RootCmd)
dbFillGapsCmdOpts.Init(dbFillGapsCmd)
dbReingestRangeCmdOpts.Init(dbReingestRangeCmd)
}

func (s *DBCommandsTestSuite) SetupSuite() {
runDBReingestRangeFn = func([]history.LedgerRange, bool, uint,
horizon.Config, ingest.StorageBackendConfig) error {
Expand Down Expand Up @@ -258,21 +244,21 @@ func (s *DBCommandsTestSuite) TestDbReingestAndFillGapsCmds() {
for _, command := range commands {
for _, tt := range tests {
s.T().Run(tt.name+"_"+command.name, func(t *testing.T) {
resetFlags()

rootCmd := NewRootCmd()
var args []string
args = append(command.cmd, tt.args...)
RootCmd.SetArgs(append([]string{
"--db-url", s.dsn,
rootCmd.SetArgs(append([]string{
"--db-url", s.db.DSN,
"--stellar-core-binary-path", "/test/core/bin/path",
}, args...))

if tt.expectError {
err := RootCmd.Execute()
err := rootCmd.Execute()
require.Error(t, err)
require.Contains(t, err.Error(), tt.errorMessage)
} else {
require.NoError(t, RootCmd.Execute())
require.NoError(t, rootCmd.Execute())
}
})
}
Expand Down
Loading