Bump core to the stable v21 build. #5323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 19ac62f.
force all integration tests to have HORIZON_INTEGRATION_TESTS_CAPTIVE_CORE_USE_DB=true by default
should always be set to true, that flag is deprecated and defaulted to true, there is no test paths validating it being false.
sreuland
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
this required more changes than probably was desired, as the core toml config bumped into larger scope of #5295 for bucketlist config cleanup, had to do some adjustments in here related to that scope to get integration passing, this seems ok in terms of limiting this scope to just getting the newer version in and #5295 still needs to be done.
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also updated some v19 images which I suspect weren't being used (or at least the tests were set up with protocol 19).