Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: upgrade postgres version to 16 #5261

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Mar 25, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

  • Run unit tests and integration tests with postgres versions 12 and 16
  • Only run integration tests with protocol 20 (we no longer need to support protocol 19)
  • Only run integration tests with captive core using buckets db since in-memory mode is deprecated

Why

We will soon be upgrading to postgres 16, see #4831

Known limitations

[N/A]

@tamirms tamirms changed the title upgrade postgres version to 16 .github/workflows: upgrade postgres version to 16 Mar 25, 2024
@tamirms tamirms marked this pull request as ready for review March 25, 2024 17:01
@tamirms tamirms requested a review from a team March 25, 2024 17:03
@tamirms tamirms mentioned this pull request Mar 25, 2024
7 tasks
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we leaving 12 just temporarily?

@tamirms
Copy link
Contributor Author

tamirms commented Mar 25, 2024

Are we leaving 12 just temporarily?

yes, once we run postgres 16 in production we can remove it from the test matrix

@tamirms tamirms enabled auto-merge (squash) March 25, 2024 19:45
@tamirms tamirms merged commit 4243033 into stellar:master Mar 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants