services/horizon: Lock ingestion while applying DB migrations #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return 0, err | ||
| } | ||
|
|
||
| tx, err := txConn.BeginTx(context.Background(), nil) |
There was a problem hiding this comment.
given that you've already used BeginTx instead of the "classic" Begin, why don't you take advantage of that and use the TxOptions ?
There was a problem hiding this comment.
Conn only exposes BeginTx method.
|
@stellar/horizon-committers PTAL, tests pass and I applied changes suggested by @tsachiherman. |
tsachiherman
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Acquire ingestion lock before applying DB migrations to stop ingestion.
Why
When applying
58_add_index_by_id_optimization.sqlmigration file we experienced a deadlock. It can happen when ingestion is running because ingestion by inserting or updating certain rows can acquireRowExclusiveLockwhich conflicts with other locks (likeShareLockwhen creating a new index).Close #4588.
Known limitations
We lock ingestion only for
upmigrations.downmigrations can remove key-value table which can lead to deadlocks.