Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate generics into Light Horizon code #4537

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Incorporate generics into Light Horizon code #4537

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7519d80
Incorporate generics into Light Horizon code
Shaptic Aug 11, 2022
59b455b
Update interface signature to include Set[T]
Shaptic Aug 11, 2022
cfdbebc
MOAR set.Set[T]s (in mocks this time)
Shaptic Aug 11, 2022
f8abcaf
Fix tests: iteration over maps isn't deterministic
Shaptic Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests: iteration over maps isn't deterministic
  • Loading branch information
@Shaptic
Shaptic committed Aug 11, 2022
commit f8abcaf2f96142b26e7bdb433de6175b5e1336af
10 changes: 7 additions & 3 deletions support/collections/maps/map_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,18 @@ import (

func TestSanity(t *testing.T) {
m := map[int]float32{1: 10, 2: 20, 3: 30}
require.Equal(t, []int{1, 2, 3}, Keys(m))
require.Equal(t, []float32{10, 20, 30}, Values(m))
for k, v := range m {
require.Contains(t, Keys(m), k)
require.Contains(t, Values(m), v)
}

// compatibility with collections/set.Set
s := set.Set[float32]{}
s.Add(1)
s.Add(2)
s.Add(3)

require.Equal(t, []float32{1, 2, 3}, Keys(s))
for item := range s {
require.Contains(t, Keys(s), item)
}
}