Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txnbuild: Enable Muxed accounts by default #4169

Merged
merged 5 commits into from
Jan 10, 2022
Merged

txnbuild: Enable Muxed accounts by default #4169

merged 5 commits into from
Jan 10, 2022

Conversation

2opremio
Copy link
Contributor

Closes #4164

Enable Muxed Accounts (SEP-23) by default:

  • Remove TransactionParams.EnableMuxedAccounts
  • Remove TransactionFromXDROptionEnableMuxedAccounts
  • Remove FeeBumpTransactionParams.EnableMuxedAccounts
  • Remove parameter withMuxedAccounts bool from all methods/functions.
  • Remove options ...TransactionFromXDROption parameter from TransactionFromXDR()
  • Rename SetOpSourceMuxedAccount() to (pre-existing) SetOpSourceAccount() which now accepts
    both G and M (muxed) account strkeys.

@2opremio 2opremio requested review from leighmcculloch and a team January 10, 2022 13:22
@2opremio 2opremio changed the title txnbuild: Enable Muxed accounts be default txnbuild: Enable Muxed accounts by default Jan 10, 2022
@2opremio 2opremio merged commit ece49d1 into stellar:master Jan 10, 2022
@2opremio 2opremio deleted the 4164-txnbuild-remove-muxed-flag branch January 10, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbellamy paulbellamy paulbellamy approved these changes

@leighmcculloch leighmcculloch Awaiting requested review from leighmcculloch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

txnbuild: Support muxed addresses (SEP-23) by default.
2 participants
@2opremio @paulbellamy