Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: add github actions workflow #3644

Merged
merged 12 commits into from
Jun 2, 2021
Merged

all: add github actions workflow #3644

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
42bfab3
all: run ci on github actions
leighmcculloch May 28, 2021
d279d2c
Update go.yml
leighmcculloch May 28, 2021
ed60619
Update go.yml
leighmcculloch May 28, 2021
9596571
Merge branch 'master' into githubactions
leighmcculloch Jun 1, 2021
37c06c7
Merge branch 'master' into githubactions
leighmcculloch Jun 2, 2021
b12161c
Try separating checks, build and test to see what that is like
leighmcculloch Jun 2, 2021
7ed05c4
Only run on push to master
leighmcculloch Jun 2, 2021
16a7f15
Merge branch 'master' into githubactions
leighmcculloch Jun 2, 2021
85057ea
Try env vars for Go versions
leighmcculloch Jun 2, 2021
92cdfe4
Try env var
leighmcculloch Jun 2, 2021
62b2013
Remove env var
leighmcculloch Jun 2, 2021
bad6914
Move test env vars out
leighmcculloch Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove env var
  • Loading branch information
@leighmcculloch
leighmcculloch authored Jun 2, 2021
commit 62b201389fe79d3b0e3a5c36bcd31a1a8fe1a4ad
15 changes: 3 additions & 12 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,13 @@ on:
branches: [master]
pull_request:

env:
GO_VERSION_LATEST: 1.16.4
GO_VERSION_PREV: 1.15.11

jobs:

check:
strategy:
matrix:
os: [ubuntu-latest]
go:
- ${{ GO_VERSION_LATEST }}
go: [1.16.4]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand All @@ -34,9 +29,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
go:
- ${{ GO_VERSION_LATEST }}
- ${{ GO_VERSION_PREV }}
go: [1.16.4, 1.15.11]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand All @@ -50,9 +43,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
go:
- ${{ GO_VERSION_LATEST }}
- ${{ GO_VERSION_PREV }}
go: [1.16.4, 1.15.11]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to prevent duplication of go/pg versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried removing the dupe with env vars, but failed to get it to work. Also, it was a little wonky because env vars have to be strings and these are arrays. I think it's not worth solving right now. According to the GitHub community forums they don't support yml anchors and aliases yet. If that gets added that'll probably be the ideal way to solve this.

pg: [9.6.5, 10]
services:
postgres:
Expand Down