Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdr: update xdr definitions #2494

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Apr 20, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This PR updates the XDR definitions to match stellar/stellar-core@b5dad7d

The most significant update to the XDR definitions is that the FeeSource of a fee bump transaction is now a muxed account instead of an account id. I have updated ingestion to ensure that the fee source muxed account is converted to an account id address before inserting data into the horizon db.

The xdr source files match the following git commit in the stellar core repo:
stellar/stellar-core@b5dad7d
@tamirms tamirms marked this pull request as ready for review April 20, 2020 15:33
@tamirms tamirms merged commit 81e6559 into stellar:release-horizon-v1.2.0 Apr 20, 2020
@tamirms tamirms deleted the fee-source-muxed branch April 20, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants