keystore: add migrate command to handle migrations #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces `keystored migrate up/down` command to handle migrations. It also defines an initial migration for the encrypted_keys table.
debnil
reviewed
May 8, 2019
| @@ -19,6 +19,28 @@ cd github.com/stellar/go/exp/services/keystore | |||
| go install ./cmd/keystored | |||
| ``` | |||
|
|
|||
| Set up `keytore` Postgres database locally: | |||
| case "up": | ||
| n, err := migrate.Exec(db, dbDriverName, keystoreMigrations, migrate.Up) | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, "error applying up migrations", err) |
There was a problem hiding this comment.
Nit: the error string could be more readable. Currently, for an error err = "test error", "error applying up migrations test error" would be printed, which is slightly confusing. (https://play.golang.org/p/zH4020sdWOr for reference.) Consider: "error applying up migrations: %v", or something of the sort.
This applies to a variety of other places below - they can quickly be found by searching for os.Stderr, and checking if the encapsulating string looks like fmt.Fprintln(os.Stderr, ..., err).
| fmt.Fprintln(os.Stdout, id) | ||
| } | ||
| } else { | ||
| fmt.Fprintln(os.Stdout, "All migrations have been unapplied!") |
There was a problem hiding this comment.
Should this text be "All migrations have been applied!"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
keystored migrate up/downcommand to handlemigrations. It also defines an initial migration for the
encrypted_keystable.