Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support/scripts/build_release_artifacts: don't build binaries based solely on semver #1209

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

ire-and-curses
Copy link
Member

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs)
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs otherwise)
  • This PR's title starts with name of package that is most changed in the PR, ex. services/friendbot

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md files, etc...) affected by this change

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if needed with deprecations, added features, breaking changes, and DB schema changes
  • I've decided if this PR requires a new major/minor version according to semver, or if it's only a patch change. The PR is targeted at the next release branch if it's not a patch change.

Summary

Fixes the situation where a tagged semVer release leads to the build system producing junk binary releases, when there is nothing to build. Closes #1208.

Goal and scope

See #1208.

Summary of changes

Build script exits with a log message if there is nothing to build.

Testing

This was tested locally with hardcoded variable names.

@ire-and-curses ire-and-curses merged commit e72cb89 into master Apr 29, 2019
@ire-and-curses ire-and-curses deleted the es-1208-binary_build branch April 29, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't build binaries if expected directory not present
2 participants