all: Bumps minimum Golang version to 1.18 (#4499)

* Run `go fmt` with go-1.19 to conform to new stds
* Now ran `go generate ./...` to conform to go-1.19
* Run `go fmt` after `go generate` in checks

.github/workflows/go.yml

@@ -11,7 +11,7 @@ jobs:
  strategy:
  matrix:
  os: [ubuntu-latest]
- go: [1.18]
+ go: [1.19]
  runs-on: ${{ matrix.os }}
  steps:
  - uses: actions/checkout@v3
@@ -31,7 +31,7 @@ jobs:
  strategy:
  matrix:
  os: [ubuntu-latest]
- go: [1.17, 1.18]
+ go: [1.18, 1.19]
  runs-on: ${{ matrix.os }}
  steps:
  - uses: actions/checkout@v3
@@ -47,7 +47,7 @@ jobs:
  strategy:
  matrix:
  os: [ubuntu-latest]
- go: [1.17, 1.18]
+ go: [1.18, 1.19]
  pg: [9.6.5, 10]
  runs-on: ${{ matrix.os }}
  services:

.github/workflows/horizon-release.yml

@@ -22,7 +22,7 @@ jobs:
 
  - uses: ./.github/actions/setup-go
  with:
- go-version: 1.17
+ go-version: 1.18
 
  - name: Check dependencies
  run: ./gomod.sh

.github/workflows/horizon.yml

@@ -12,7 +12,7 @@ jobs:
  strategy:
  matrix:
  os: [ubuntu-latest]
- go: [1.17, 1.18]
+ go: [1.18, 1.19]
  pg: [9.6.5]
  ingestion-backend: [db, captive-core, captive-core-remote-storage]
  protocol-version: [18, 19]

exp/orderbook/pools.go

@@ -87,7 +87,7 @@ func makeTrade(
 // CalculatePoolPayout calculates the amount of `reserveB` disbursed from the
 // pool for a `received` amount of `reserveA` . From CAP-38:
 //
-// y = floor[(1 - F) Yx / (X + x - Fx)]
+// y = floor[(1 - F) Yx / (X + x - Fx)]
 //
 // It returns false if the calculation overflows.
 func CalculatePoolPayout(reserveA, reserveB, received xdr.Int64, feeBips xdr.Int32, calculateRoundingSlippage bool) (xdr.Int64, xdr.Int64, bool) {
@@ -160,7 +160,7 @@ func CalculatePoolPayout(reserveA, reserveB, received xdr.Int64, feeBips xdr.Int
 // CalculatePoolExpectation determines how much of `reserveA` you would need to
 // put into a pool to get the `disbursed` amount of `reserveB`.
 //
-// x = ceil[Xy / ((Y - y)(1 - F))]
+// x = ceil[Xy / ((Y - y)(1 - F))]
 //
 // It returns false if the calculation overflows.
 func CalculatePoolExpectation(

exp/orderbook/pools_test.go

@@ -336,7 +336,7 @@ func TestCalculatePoolPayoutRoundingSlippage(t *testing.T) {
 // CalculatePoolPayout calculates the amount of `reserveB` disbursed from the
 // pool for a `received` amount of `reserveA` . From CAP-38:
 //
-// y = floor[(1 - F) Yx / (X + x - Fx)]
+// y = floor[(1 - F) Yx / (X + x - Fx)]
 //
 // It returns false if the calculation overflows.
 func calculatePoolPayoutBig(reserveA, reserveB, received xdr.Int64, feeBips xdr.Int32) (xdr.Int64, xdr.Int64, bool) {
@@ -387,7 +387,7 @@ func calculatePoolPayoutBig(reserveA, reserveB, received xdr.Int64, feeBips xdr.
 // calculatePoolExpectation determines how much of `reserveA` you would need to
 // put into a pool to get the `disbursed` amount of `reserveB`.
 //
-// x = ceil[Xy / ((Y - y)(1 - F))]
+// x = ceil[Xy / ((Y - y)(1 - F))]
 //
 // It returns false if the calculation overflows.
 func calculatePoolExpectationBig(

exp/orderbook/search.go

@@ -237,11 +237,11 @@ func search(
 // edges in `graph.edgesForSellingAsset` are traversed.
 //
 // The DFS maintains the following invariants:
-// - no node is repeated
-// - no offers are consumed from the `ignoreOffersFrom` account
-// - each payment path must begin with an asset in `targetAssets`
-// - also, the required source asset amount cannot exceed the balance in
-// `targetAssets`
+//  - no node is repeated
+//  - no offers are consumed from the `ignoreOffersFrom` account
+//  - each payment path must begin with an asset in `targetAssets`
+//  - also, the required source asset amount cannot exceed the balance in
+//  `targetAssets`
 type sellingGraphSearchState struct {
  graph *OrderBookGraph
  destinationAssetString string
@@ -339,10 +339,10 @@ func (state *sellingGraphSearchState) consumePool(
 // edges in `graph.edgesForBuyingAsset` are traversed.
 //
 // The DFS maintains the following invariants:
-// - no node is repeated
-// - no offers are consumed from the `ignoreOffersFrom` account
-// - each payment path must terminate with an asset in `targetAssets`
-// - each payment path must begin with `sourceAsset`
+//  - no node is repeated
+//  - no offers are consumed from the `ignoreOffersFrom` account
+//  - each payment path must terminate with an asset in `targetAssets`
+//  - each payment path must begin with `sourceAsset`
 type buyingGraphSearchState struct {
  graph *OrderBookGraph
  sourceAssetString string

go.mod

@@ -1,6 +1,6 @@
 module github.com/stellar/go
 
-go 1.17
+go 1.18
 
 require (
  firebase.google.com/go v3.12.0+incompatible

gogenerate.sh

@@ -2,7 +2,7 @@
 set -e
 
 printf "Running go generate...\n"
-go generate ./...
+go generate ./... && go fmt ./...
 
 printf "Checking for no diff...\n"
 git diff --exit-code || (echo "Files changed after running go generate. Run go generate ./... locally and update generated files." && exit 1)