Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Münchner Stadtbibliothek (only SZ via munzinger.de) #399

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Strubbl
Copy link

@Strubbl Strubbl commented Dec 19, 2023

This PR supersedes #184.

I am not sure about the change from hardcoded Spiegel to SZ in the munzinger search URL. Do you have any hint about how to implement this better? With a separate Sources?

The change in the extractor is done to really remove the quotes from the query parameter. This is done, because special chars are also removed and thus an exact search for the query does not reveal any results anymore.

I tested my changes successfully with the following URLs

fixes #110
fixes #186
fixes #250
fixes #313
closes #184

This change is necessary in order to work for Münchner Stadtbibliothek
to fetch SZ articles.
@Strubbl Strubbl changed the title Add Münchner Stadtbibliothek Add Münchner Stadtbibliothek (only SZ via munzinger.de) Dec 19, 2023
@Strubbl
Copy link
Author

Strubbl commented Dec 19, 2023

Thanks to @darkdragon-001 for the initial start in PR 184. I reused the portalId which saved me some time.

@Pfaufisch
Copy link

@Strubbl: It looks like the Münchner Stadtbibliothek now offers access to Genios as well. If you're still working on this, I'd appreciate if you consider adding support for Genios.

@darkdragon-001
Copy link
Contributor

FYI I added support via Genios in #442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants