Loss progress tests #176
Merged
Loss progress tests #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test_loss_progress test to test_approximators/test_fit.py. Updated fixtures in test_approximators/conftest.py to use OfflineDataset and CouplingFlow.
Refactored test to also test for validation loss in test_approximators/test_fit.py. Added Normal Distribution Simulator class. Refactored test_approximators/conftest.py to use OfflineDataset and NormalSimulator. Added NormalSimulator import to simulators/__init__.py.
Added fix for test failure on Keras Ubuntu output
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## streamlined-backend #176 +/- ##
=======================================================
- Coverage 67.62% 66.82% -0.80%
=======================================================
Files 88 92 +4
Lines 1640 1688 +48
=======================================================
+ Hits 1109 1128 +19
- Misses 531 560 +29 ☔ View full report in Codecov by Sentry. |
stefanradev93
merged commit ff35ca6
into
stefanradev93:streamlined-backend
2 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements changes for Jira BF-28:
Added tests to inspect loss progress and loss on the progress bar
Changes:
test_approximators/test_fit.pytest_loss_progressto monitor the training loss progression in stdout. This is done by checking that the loss reported for each batch is not NaN, and ensuring that the captured epoch summary loss and validation loss match the model's historytest_approximators/conftest.pyinference_networkfixture to useCouplingFlowapproximatorfixturedatasetfixturesimulatorfixture to use newNormalSimulatortrain_datasetfixturevalidation_datasetfixturesimulators/normal_simulator.pyNormalSimulatorwith sampling for fit testssimulators/__init__.pyNormalSimulator