Faster minification #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +84,7 @@ | |||
| </footer> | |||
| <script>var results = [ | |||
| <%= results.map( function ( result ) { | |||
| return '/* ' + ( new Date( result.timestamp ) ) + ' | ' + result.timestamp + '.json */\n' + JSON.stringify( result, null, 2 ) ; | |||
There was a problem hiding this comment.
Hmm, that was a feature request by @Augenfeind.
@Augenfeind. What do you think, are you still checking the html json?
Can we remove it?
|
@Augenfeind can you please comment, if you still need the formatted json in index.html?! Thanks. :) |
|
@gmetais Looks good for me. Think will merge soon. Hmm, but code coverage decreased, but will check on that myself. |
Could it be an option ? |
|
Let's wait for a statement of him. |
stefanjudis
added a commit
that referenced
this pull request
May 15, 2014
Faster minification - fixes #84
|
@gmetais Thanks for that. Great job! :) Will be included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to keep the HTML minified, that's a good news.
I also minified the JSON, if someone want's to read it without minification, he can still open the original phantomas JSON file.