Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

252 Timeout when navigating to thetrainline.com #163

Closed
qashahin opened this issue Jan 4, 2017 · 5 comments
Closed

252 Timeout when navigating to thetrainline.com #163

qashahin opened this issue Jan 4, 2017 · 5 comments

Comments

@qashahin
Copy link

qashahin commented Jan 4, 2017

Hi,

When navigating to 'https://www.thetrainline.com/' I get a 252 issue. Having looked through your issues I found that this may have been caused by a timeout.

When typing 'phantomas --url https://www.thetrainline.com/' on the command line I also get a 252 timeout issue however phantomas also provides all the data e.g

* requests: 140
* gzipRequests: 29
* postRequests: 0
* httpsRequests: 140
* notFound: 0
* bodySize: 1534495 bytes.....etc

I tried to increase the timeout in the Gruntfile however that did not help.

module.exports = function(grunt) {
    grunt.initConfig({
        phantomas: {
            site : {
                options : {
                    indexPath : './phantomas/',
                    options   : {
                        'timeout' : 160
                    },
                    url       : 'https://www.thetrainline.com/',
                    buildUi   : true,
                    numberOfRuns : 1
                }
            }
        }
    });

    grunt.loadNpmTasks('grunt-phantomas');
    grunt.registerTask('default', ['phantomas']);
};

When navigating to other sites such as Google the issue does not appear to present itself.

Can you provide some assistance please as to how I can resolve this? As said I tried to set the timeout to 30, 60, 120 and 160 as well as decrease the number of runs to 1 yet the 252 persists.

Best,
QAShahin

@stefanjudis
Copy link
Owner

I'll try to tackle a few open issues here on the weekend. :)

Feel free to remind me, in case I forgot. :)

@qashahin
Copy link
Author

qashahin commented Jan 5, 2017

@stefanjudis Thank you very much. It would be great if you lend a hand with this.

@stefanjudis
Copy link
Owner

@qashahin

I changed the behavior and it will now use metrics even when the runs fail.

This is a log against your site.

Running "phantomas:grunt" (phantomas) task

PHANTOMAS EXECUTION(S) STARTED.
>> Phantomas execution failed with 252 but returned metrics.
>> Phantomas execution successful.
>> Phantomas execution failed with 252 but returned metrics.
>> Phantomas execution failed with 252 but returned metrics.
>> Phantomas execution successful.
>> 5 Phantomas execution(s) done -> checking results:

Will do some testing and then releasse a new version.

stefanjudis added a commit that referenced this issue Jan 8, 2017
fix evaluation of metrics for failed runs - #163
@stefanjudis
Copy link
Owner

Fixed with #165.

Let me know when you have further problems. Will release v.0.13.0 now.

@qashahin
Copy link
Author

qashahin commented Jan 9, 2017

@stefanjudis Thank you greatly for your time spent on this, this has really helped me a lot. I am forever grateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants