[FEATURE] Use rpc proxy #747
Conversation
fluffy/conf.nim
Outdated
| @@ -14,6 +14,7 @@ import | |||
| const | |||
| DefaultListenAddress* = (static ValidIpAddress.init("0.0.0.0")) | |||
| DefaultAdminListenAddress* = (static ValidIpAddress.init("127.0.0.1")) | |||
| DefaultProxyAddrss* = (static "http:https://127.0.0.1:8546") | |||
There was a problem hiding this comment.
| DefaultProxyAddrss* = (static "http:https://127.0.0.1:8546") | |
| DefaultProxyAddress* = (static "http:https://127.0.0.1:8546") |
| @@ -92,6 +93,13 @@ type | |||
| desc: "if provided, enables getting data from bridge node" | |||
| name: "bridge-client-uri" .}: Option[string] | |||
|
|
|||
| # it makes little sense to have default value here in final release, but until then | |||
There was a problem hiding this comment.
The http:https://127.0.0.1:8546 is fine I think for now. (Either that or 8545 but then we have to change our own local port).
Eventually the proxy should become optional (or might be removed completely), and should be default disabled, but only after we have implemented (most) rpc calls.
There was a problem hiding this comment.
yep that was my thinking about it, this is just like additional wheels in bike and ultimatly we may get rid of it
| rpcHttpServer.installEthApiHandlers() | ||
| rpcHttpServer.start() | ||
| let ta = initTAddress(config.rpcAddress, config.rpcPort) | ||
| var rpcHttpServerWithProxy = newRpcHttpProxy([$ta]) |
There was a problem hiding this comment.
Ok for now, but we should get a newRpcHttpProxy which takes in the TransportAddress
There was a problem hiding this comment.
I will make a quick pr in upstream repo to add additional constructor
| rpcHttpServerWithProxy.installEthApiHandlers() | ||
| # TODO for now we can only proxy to local node (or remote one without ssl) to make it possible | ||
| # to call infura https://github.com/status-im/nim-json-rpc/pull/101 needs to get merged for http client to support https/ | ||
| waitFor rpcHttpServerWithProxy.start(config.proxyUri) |
There was a problem hiding this comment.
This could use some further error handling eventually.
There was a problem hiding this comment.
I agree, for now as nothing is implemented it makes little sense to start without without working proxy, in the future when there will some working methods, it will be better to catch error here and log thats fluffy is starting without working proxy so some methods may not work as intended.
Proxy all rpc call to provided uri