fixes #421, each test suite have their own skip table #423
Conversation
tests/test_helpers.nim
Outdated
| @@ -171,7 +65,7 @@ proc lacksSupportedForks*(fixtures: JsonNode): bool = | |||
|
|
|||
| var status = initOrderedTable[string, OrderedTable[string, Status]]() | |||
|
|
|||
| macro jsonTest*(s: static[string], handler: untyped): untyped = | |||
| macro jsonTest*(s: static[string], handler: untyped, skipTest: untyped): untyped = | |||
There was a problem hiding this comment.
We can't give skipTest the default value of skipNothing?
There was a problem hiding this comment.
sure we can. my memory must be corrupted when I am not using default value for skipTest.
fixed.
|
It's hard to tell whether the CI failure here is genuine or not. I'll close and re-open to give it another try. |
|
I could not reproduce the problem running archlinux in a virtualbox. |
|
Could it be a lingering server blocking a port? https://travis-ci.org/status-im/nimbus/jobs/615173024#L7175 Maybe we don't wait for it to close properly before starting the next test suite. |
|
hmm, strange that with that error those rpc tests actually manage to pass, no? |
|
last time I saw both of travis CI failed, now it's only one of them. could it be another hiccup? |
|
Restarted. |
jangko
force-pushed
the
tester_skip_table
branch
2 times, most recently
from
5c22ab8
to
bed169c
Compare
jangko
force-pushed
the
tester_skip_table
branch
from
bed169c
to
3683ce2
Compare
|
finally tests are green. |
less confusion about which test suite should skip what tests