Refactor tests: remove bash/unix shell dependency for tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yglukhov
suggested changes
Apr 3, 2018
.travis.yml
Outdated
| @@ -5,4 +5,4 @@ before_install: | |||
| - docker pull yglukhov/nim-base | |||
| script: | |||
| - docker run yglukhov/nim-base nim --version | |||
| - docker run -v "$(pwd):/project" -w /project yglukhov/nim-base /bin/bash -c "nimble install -y && ./tests/build_test.sh && ./tests/test.sh" | |||
| - docker run -v "$(pwd):/project" -w /project yglukhov/nim-base /bin/bash -c "nimble install -y && nimble test" | |||
There was a problem hiding this comment.
Let's use statusteam/nim-base instead.
yglukhov
reviewed
Apr 4, 2018
.travis.yml
Outdated
| - docker run yglukhov/nim-base nim --version | ||
| - docker run -v "$(pwd):/project" -w /project yglukhov/nim-base /bin/bash -c "nimble install -y && ./tests/build_test.sh && ./tests/test.sh" | ||
| - docker run -v "$(pwd):/project" -w /project yglukhov/nim-base nim --version | ||
| - docker run -v "$(pwd):/project" -w /project yglukhov/nim-base nimble install -y |
There was a problem hiding this comment.
This will not work, nimble install -y and nimble test have to be in the same docker run. Also let's use statusteam/nim-base instead of yglukhov/nim-base please ;)
There was a problem hiding this comment.
ah, I pasted from secp256k1 and didn't see that the docker was wrong here too
yglukhov
reviewed
Apr 4, 2018
.travis.yml
Outdated
| - docker run yglukhov/nim-base nim --version | ||
| - docker run -v "$(pwd):/project" -w /project yglukhov/nim-base /bin/bash -c "nimble install -y && ./tests/build_test.sh && ./tests/test.sh" | ||
| - docker run -v "$(pwd):/project" -w /project yglukhov/nim-base nim --version | ||
| - docker run -v "$(pwd):/project" -w /project yglukhov/nim-base nimble refresh |
There was a problem hiding this comment.
Nope, still won't work. Use this please:
- docker run -v "$(pwd):/project" -w /project statusteam/nim-base sh -c "nimble install -dy && nimble test"
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the dependency on bash/scripting shell and change the following:
nimble testtests file starting with a t in the tests directory by default)This does not address the following:
alehander42/nim-rlp#fix-ordinaltostatus-im/nim-rlp#master